Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool column chunk buffer size #1953

Merged
merged 1 commit into from
Aug 28, 2023

Initialize buffer for bools to match the bitpacked size

62d50f3
Select commit
Loading
Failed to load commit list.
Merged

Fix bool column chunk buffer size #1953

Initialize buffer for bools to match the bitpacked size
62d50f3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 24, 2023 in 0s

89.67% (target 80.00%)

View this Pull Request on Codecov

89.67% (target 80.00%)

Details

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.20% ⚠️

Comparison is base (2c45803) 89.86% compared to head (62d50f3) 89.67%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
- Coverage   89.86%   89.67%   -0.20%     
==========================================
  Files         873      870       -3     
  Lines       32066    32022      -44     
==========================================
- Hits        28817    28716     -101     
- Misses       3249     3306      +57     
Files Changed Coverage Δ
src/storage/copier/column_chunk.cpp 83.93% <87.50%> (+0.04%) ⬆️
src/include/storage/copier/column_chunk.h 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.