Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove query normalizer #1952

Merged
merged 1 commit into from
Aug 24, 2023
Merged

remove query normalizer #1952

merged 1 commit into from
Aug 24, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR removes query normalizer and directly generate a normalized query after binding.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.19% ⚠️

Comparison is base (2c45803) 89.86% compared to head (c867eb9) 89.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1952      +/-   ##
==========================================
- Coverage   89.86%   89.67%   -0.19%     
==========================================
  Files         873      870       -3     
  Lines       32066    32019      -47     
==========================================
- Hits        28817    28714     -103     
- Misses       3249     3305      +56     
Files Changed Coverage Δ
src/binder/bind/bind_projection_clause.cpp 96.77% <ø> (-0.03%) ⬇️
src/binder/bind/bind_reading_clause.cpp 95.91% <ø> (ø)
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/binder/query/normalized_single_query.h 100.00% <ø> (ø)
src/binder/bind/bind_query.cpp 100.00% <100.00%> (ø)
src/binder/binder.cpp 96.36% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit fb7cd9f into master Aug 24, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the remove-query-normalizer branch August 24, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants