Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include functions from arrow feature in docs.rs rust docs #1951

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

benjaminwinger
Copy link
Collaborator

The arrow feature currently shows up on docs.rs (https://docs.rs/crate/kuzu/0.0.7/features), but the iter_arrow function it provides doesn't, since the arrow feature is disabled by default. However you can set the features used to build the docs on docs.rs via a docs.rs-specific table in Cargo.toml.

This won't have any effect until the next release, but the docs can be built manually with the arrow feature (e.g. DOCS_RS=1 cargo build --features arrow (setting the DOCS_RS env variable skips building the kuzu C++ library since it's not needed for documentation)).

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c45803) 89.86% compared to head (53c1bc9) 89.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1951   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         873      873           
  Lines       32066    32066           
=======================================
  Hits        28817    28817           
  Misses       3249     3249           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 9399be0 into master Aug 24, 2023
10 checks passed
@benjaminwinger benjaminwinger deleted the docs_rs_features branch August 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants