Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top K optimizer #1949

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add top K optimizer #1949

merged 1 commit into from
Aug 22, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (f6154ec) 89.87% compared to head (beb15e6) 89.87%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1949   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files         873      873           
  Lines       32062    32066    +4     
=======================================
+ Hits        28815    28819    +4     
  Misses       3247     3247           
Files Changed Coverage Δ
src/optimizer/optimizer.cpp 100.00% <ø> (ø)
src/planner/plan/plan_projection.cpp 100.00% <ø> (ø)
src/storage/local_table.cpp 89.90% <ø> (ø)
src/planner/operator/logical_order_by.cpp 91.30% <71.42%> (-8.70%) ⬇️
...rc/include/planner/logical_plan/logical_order_by.h 100.00% <100.00%> (ø)
src/optimizer/projection_push_down_optimizer.cpp 98.79% <100.00%> (+<0.01%) ⬆️
src/planner/operator/logical_limit.cpp 100.00% <100.00%> (ø)
src/processor/map/map_order_by.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -33,6 +34,9 @@ void Optimizer::optimize(planner::LogicalPlan* plan) {
auto hashJoinSIPOptimizer = HashJoinSIPOptimizer();
hashJoinSIPOptimizer.rewrite(plan);

// auto topKOptimizer = TopKOptimizer();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@andyfengHKU andyfengHKU merged commit 2c45803 into master Aug 22, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the top-k-optmizer branch August 22, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants