Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge skip limit #1948

Merged
merged 1 commit into from
Aug 22, 2023
Merged

merge skip limit #1948

merged 1 commit into from
Aug 22, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR merge logical skip and limit into one operator

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (ab903ed) 89.89% compared to head (f6154ec) 89.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   89.89%   89.87%   -0.03%     
==========================================
  Files         877      873       -4     
  Lines       32097    32062      -35     
==========================================
- Hits        28854    28815      -39     
- Misses       3243     3247       +4     
Files Changed Coverage Δ
...r/query/return_with_clause/bound_projection_body.h 100.00% <ø> (ø)
src/include/optimizer/factorization_rewriter.h 100.00% <ø> (ø)
src/include/optimizer/logical_operator_visitor.h 94.87% <ø> (-0.19%) ⬇️
...rc/include/planner/logical_plan/logical_operator.h 90.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
src/include/processor/plan_mapper.h 100.00% <ø> (ø)
src/optimizer/factorization_rewriter.cpp 100.00% <ø> (ø)
src/optimizer/logical_operator_visitor.cpp 98.50% <ø> (-0.06%) ⬇️
src/planner/operator/logical_operator.cpp 83.33% <ø> (-0.23%) ⬇️
src/processor/map/plan_mapper.cpp 98.06% <ø> (-0.04%) ⬇️
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit e69f0a7 into master Aug 22, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the merge-skip-limit branch August 22, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants