Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust deployment #1932

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Fix Rust deployment #1932

merged 5 commits into from
Aug 15, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Fixes #1927.

The rustup install should probably be added to the dockerfile instead of included in the workflow, but I thought it would be easier to test it this way.

I've tested it and it's working: https://github.com/kuzudb/kuzu/actions/runs/5858238195/job/15881791303

I also had to fix the version parsing since 0.0.6.5 is not a valid semantic version (so I made the fourth component be turned into a pre-release version, e.g. 0.0.6-5).

@benjaminwinger benjaminwinger changed the title Rustup Fix Rust deployment Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f4f1a77) 89.84% compared to head (54df97e) 89.83%.
Report is 2 commits behind head on master.

❗ Current head 54df97e differs from pull request most recent head 757a4b8. Consider uploading reports for the commit 757a4b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1932      +/-   ##
==========================================
- Coverage   89.84%   89.83%   -0.01%     
==========================================
  Files         867      867              
  Lines       31557    31557              
==========================================
- Hits        28351    28350       -1     
- Misses       3206     3207       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim
Copy link
Collaborator

mewim commented Aug 15, 2023

It seems this breaks rust format: https://github.com/kuzudb/kuzu/actions/runs/5858442707/job/15894933233?pr=1931

Let's breifly discuss it tomorrow. Redeploying the Docker containers maybe required to make this work.

@benjaminwinger
Copy link
Collaborator Author

Oh, yes with the minimal profile it won't install rustfmt. Either dropping the --profile minimal, or adding rustup component add rustfmt should fix that.

@mewim
Copy link
Collaborator

mewim commented Aug 15, 2023

I think we should consider seperate the building environment from the regular testing environment. Since the builder now mutates the environment by running rustup, we should not run it on the testing container, so we can keep a stable environment for testing.

@mewim
Copy link
Collaborator

mewim commented Aug 15, 2023

Or, we can just install rust via rustup in Dockerfile and avoid running it everytime during the build process.

@benjaminwinger
Copy link
Collaborator Author

Yes, I think installing it in the Dockerfile is a better idea.

I take it it's not starting up a fresh container per job/workflow then? I hadn't realised that this would propagate to the other jobs.

@mewim
Copy link
Collaborator

mewim commented Aug 15, 2023

We have a fixed set of containers for each environment instead of launching a new one for each job. I will redeploy the containers to see if it fixes the issue.

@mewim
Copy link
Collaborator

mewim commented Aug 15, 2023

@mewim mewim merged commit 9529003 into master Aug 15, 2023
0 of 8 checks passed
@mewim mewim deleted the rustup branch August 15, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust deployment failed
2 participants