-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rust deployment #1932
Fix Rust deployment #1932
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
- Coverage 89.84% 89.83% -0.01%
==========================================
Files 867 867
Lines 31557 31557
==========================================
- Hits 28351 28350 -1
- Misses 3206 3207 +1 ☔ View full report in Codecov by Sentry. |
It seems this breaks rust format: https://github.com/kuzudb/kuzu/actions/runs/5858442707/job/15894933233?pr=1931 Let's breifly discuss it tomorrow. Redeploying the Docker containers maybe required to make this work. |
Oh, yes with the |
I think we should consider seperate the building environment from the regular testing environment. Since the builder now mutates the environment by running |
Or, we can just install rust via |
Yes, I think installing it in the Dockerfile is a better idea. I take it it's not starting up a fresh container per job/workflow then? I hadn't realised that this would propagate to the other jobs. |
We have a fixed set of containers for each environment instead of launching a new one for each job. I will redeploy the containers to see if it fixes the issue. |
Fixes #1927.
The rustup install should probably be added to the dockerfile instead of included in the workflow, but I thought it would be easier to test it this way.
I've tested it and it's working: https://github.com/kuzudb/kuzu/actions/runs/5858238195/job/15881791303
I also had to fix the version parsing since
0.0.6.5
is not a valid semantic version (so I made the fourth component be turned into a pre-release version, e.g.0.0.6-5
).