Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnest arbitrary subquery #1930

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Unnest arbitrary subquery #1930

merged 1 commit into from
Aug 15, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR implements unnest arbitrary subquery with hash join based execution.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 96.81% and project coverage change: +0.02% 🎉

Comparison is base (b0bbb09) 89.85% compared to head (2d5cfb8) 89.87%.
Report is 1 commits behind head on master.

❗ Current head 2d5cfb8 differs from pull request most recent head e4bb187. Consider uploading reports for the commit e4bb187 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1930      +/-   ##
==========================================
+ Coverage   89.85%   89.87%   +0.02%     
==========================================
  Files         867      873       +6     
  Lines       31567    31551      -16     
==========================================
- Hits        28363    28357       -6     
+ Misses       3204     3194      -10     
Files Changed Coverage Δ
src/include/binder/expression/expression.h 91.30% <ø> (ø)
src/include/optimizer/factorization_rewriter.h 100.00% <ø> (ø)
...include/planner/join_order/cardinality_estimator.h 100.00% <ø> (ø)
...rc/include/planner/logical_plan/logical_operator.h 90.00% <ø> (ø)
src/include/processor/plan_mapper.h 100.00% <ø> (ø)
src/optimizer/projection_push_down_optimizer.cpp 98.78% <ø> (ø)
src/binder/expression/expression.cpp 82.97% <85.71%> (+0.05%) ⬆️
src/planner/plan/plan_subquery.cpp 95.31% <90.00%> (+3.00%) ⬆️
src/planner/plan/plan_join_order.cpp 96.90% <94.93%> (-0.97%) ⬇️
...lude/optimizer/correlated_subquery_unnest_solver.h 100.00% <100.00%> (ø)
... and 25 more

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/planner/logical_plan/logical_hash_join.h Outdated Show resolved Hide resolved
src/include/planner/logical_plan/logical_hash_join.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit c90fb84 into master Aug 15, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the unnest-subquery branch August 15, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants