Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic framework of local storage for node group #1928

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 13, 2023

No description provided.

@ray6080 ray6080 changed the title [WIP] Basic framework of local storage for node group Basic framework of local storage for node group Aug 14, 2023
@ray6080 ray6080 marked this pull request as ready for review August 14, 2023 14:37
src/common/exception.cpp Show resolved Hide resolved
src/include/storage/local_storage.h Outdated Show resolved Hide resolved
src/include/storage/local_table.h Outdated Show resolved Hide resolved
src/storage/local_table.cpp Outdated Show resolved Hide resolved
src/storage/storage_manager.cpp Outdated Show resolved Hide resolved
test/transaction/transaction_test.cpp Outdated Show resolved Hide resolved
test/transaction/transaction_test.cpp Outdated Show resolved Hide resolved
test/transaction/transaction_test.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 78.61% and project coverage change: -0.16% ⚠️

Comparison is base (b0bbb09) 89.85% compared to head (ef990e0) 89.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
- Coverage   89.85%   89.69%   -0.16%     
==========================================
  Files         867      871       +4     
  Lines       31567    31828     +261     
==========================================
+ Hits        28363    28548     +185     
- Misses       3204     3280      +76     
Files Changed Coverage Δ
src/include/common/exception.h 77.27% <ø> (ø)
src/include/common/types/ku_string.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/include/storage/store/node_table.h 100.00% <ø> (ø)
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 33.60% <0.00%> (-0.01%) ⬇️
.../storage/in_mem_storage_structure/in_mem_lists.cpp 65.97% <0.00%> (-0.42%) ⬇️
src/storage/storage_structure/disk_array.cpp 94.63% <ø> (ø)
src/storage/copier/string_column_chunk.cpp 81.08% <57.14%> (-11.40%) ⬇️
src/include/storage/copier/column_chunk.h 97.36% <66.66%> (-2.64%) ⬇️
src/include/storage/storage_utils.h 97.89% <66.66%> (-2.11%) ⬇️
... and 22 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 20f2adc into master Aug 16, 2023
9 of 10 checks passed
@ray6080 ray6080 deleted the local-storage branch August 16, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants