Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add node property #1923

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fix add node property #1923

merged 1 commit into from
Aug 14, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Aug 11, 2023

Fix add node property which is disabled in the previous pr.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 87.14% and project coverage change: +0.08% 🎉

Comparison is base (86b089d) 89.81% compared to head (a82effe) 89.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   89.81%   89.90%   +0.08%     
==========================================
  Files         867      867              
  Lines       31404    31490      +86     
==========================================
+ Hits        28207    28311     +104     
+ Misses       3197     3179      -18     
Files Changed Coverage Δ
src/include/main/connection.h 100.00% <ø> (ø)
...include/processor/operator/ddl/add_node_property.h 100.00% <ø> (+100.00%) ⬆️
src/include/processor/operator/ddl/add_property.h 100.00% <ø> (ø)
src/include/storage/copier/column_chunk.h 100.00% <ø> (ø)
src/include/storage/copier/string_column_chunk.h 100.00% <ø> (ø)
src/include/storage/copier/struct_column_chunk.h 100.00% <ø> (ø)
src/include/storage/copier/var_list_column_chunk.h 100.00% <ø> (ø)
src/include/storage/storage_structure/disk_array.h 89.18% <ø> (ø)
src/include/storage/store/node_table.h 100.00% <ø> (+30.76%) ⬆️
src/storage/wal_replayer.cpp 84.30% <30.00%> (-1.00%) ⬇️
... and 18 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/storage/copier/column_chunk.cpp Outdated Show resolved Hide resolved
src/storage/copier/struct_column_chunk.cpp Outdated Show resolved Hide resolved
test/runner/e2e_ddl_test.cpp Outdated Show resolved Hide resolved
src/storage/store/node_table.cpp Outdated Show resolved Hide resolved
src/storage/copier/column_chunk.cpp Outdated Show resolved Hide resolved
src/storage/copier/var_list_column_chunk.cpp Outdated Show resolved Hide resolved
src/storage/copier/string_column_chunk.cpp Outdated Show resolved Hide resolved
src/include/storage/copier/column_chunk.h Outdated Show resolved Hide resolved
src/storage/copier/column_chunk.cpp Show resolved Hide resolved
src/storage/copier/column_chunk.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 3872875 into master Aug 14, 2023
10 checks passed
@acquamarin acquamarin deleted the add-prop-fix branch August 14, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants