Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic hash join #1919

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Generic hash join #1919

merged 1 commit into from
Aug 11, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 94.93% and project coverage change: +0.02% 🎉

Comparison is base (e81f88c) 89.85% compared to head (83ef47a) 89.88%.

❗ Current head 83ef47a differs from pull request most recent head e8e0283. Consider uploading reports for the commit e8e0283 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   89.85%   89.88%   +0.02%     
==========================================
  Files         869      867       -2     
  Lines       31180    31305     +125     
==========================================
+ Hits        28018    28137     +119     
- Misses       3162     3168       +6     
Files Changed Coverage Δ
src/include/binder/expression/expression.h 91.30% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/planner/logical_plan/schema.h 100.00% <ø> (ø)
...c/include/processor/operator/intersect/intersect.h 100.00% <ø> (ø)
src/planner/operator/schema.cpp 88.46% <ø> (+6.10%) ⬆️
src/common/types/types.cpp 92.73% <83.33%> (-0.14%) ⬇️
...c/processor/operator/hash_join/join_hash_table.cpp 93.58% <92.20%> (-4.73%) ⬇️
src/binder/expression/expression.cpp 82.92% <92.30%> (+4.35%) ⬆️
src/planner/operator/logical_hash_join.cpp 91.56% <96.42%> (-0.84%) ⬇️
src/include/common/data_chunk/data_chunk_state.h 100.00% <100.00%> (ø)
... and 15 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/common/types/types.cpp Show resolved Hide resolved
src/include/binder/expression/expression.h Show resolved Hide resolved
src/include/common/data_chunk/data_chunk_state.h Outdated Show resolved Hide resolved
src/include/binder/expression/expression.h Show resolved Hide resolved
src/include/processor/operator/hash_join/hash_join_build.h Outdated Show resolved Hide resolved
src/processor/map/map_hash_join.cpp Outdated Show resolved Hide resolved
src/processor/map/map_hash_join.cpp Outdated Show resolved Hide resolved
src/processor/operator/hash_join/join_hash_table.cpp Outdated Show resolved Hide resolved
src/processor/operator/hash_join/join_hash_table.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 0a50c8d into master Aug 11, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the generic-hash-join branch August 11, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants