Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet loader fix #1914

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Parquet loader fix #1914

merged 1 commit into from
Aug 10, 2023

Conversation

acquamarin
Copy link
Collaborator

Fix parquet loader

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 96.61% and project coverage change: +0.09% 🎉

Comparison is base (7dd607b) 89.75% compared to head (bf59483) 89.85%.

❗ Current head bf59483 differs from pull request most recent head eb52261. Consider uploading reports for the commit eb52261 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
+ Coverage   89.75%   89.85%   +0.09%     
==========================================
  Files         869      869              
  Lines       31143    31138       -5     
==========================================
+ Hits        27953    27978      +25     
+ Misses       3190     3160      -30     
Files Changed Coverage Δ
src/storage/copier/var_list_column_chunk.cpp 92.95% <90.47%> (+4.82%) ⬆️
src/include/storage/copier/string_column_chunk.h 100.00% <100.00%> (ø)
src/include/storage/copier/var_list_column_chunk.h 100.00% <100.00%> (ø)
src/storage/copier/string_column_chunk.cpp 89.61% <100.00%> (-0.39%) ⬇️
src/storage/storage_manager.cpp 96.66% <100.00%> (+0.51%) ⬆️
src/storage/store/string_node_column.cpp 98.48% <100.00%> (+0.30%) ⬆️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin requested a review from ray6080 August 9, 2023 17:34
src/include/storage/store/string_node_column.h Outdated Show resolved Hide resolved
src/include/storage/store/string_node_column.h Outdated Show resolved Hide resolved
src/storage/copier/var_list_column_chunk.cpp Outdated Show resolved Hide resolved
src/storage/store/string_node_column.cpp Outdated Show resolved Hide resolved
src/storage/copier/var_list_column_chunk.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit fc32db0 into master Aug 10, 2023
10 checks passed
@acquamarin acquamarin deleted the parquet-loader-fix branch August 10, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants