Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework node table insert interface #1910

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Rework node table insert interface #1910

merged 1 commit into from
Aug 10, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e8d1a08) 89.72% compared to head (b0e8e72) 89.72%.

❗ Current head b0e8e72 differs from pull request most recent head 2cf6cc2. Consider uploading reports for the commit 2cf6cc2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1910   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files         869      869           
  Lines       31101    31111   +10     
=======================================
+ Hits        27906    27915    +9     
- Misses       3195     3196    +1     
Files Changed Coverage Δ
src/include/storage/store/node_table.h 69.23% <ø> (ø)
src/include/storage/store/rel_table.h 100.00% <ø> (ø)
src/binder/bind/bind_updating_clause.cpp 96.09% <100.00%> (-0.09%) ⬇️
...e/binder/query/updating_clause/bound_create_info.h 100.00% <100.00%> (ø)
...e/planner/logical_plan/persistent/logical_create.h 100.00% <100.00%> (ø)
...de/processor/operator/persistent/insert_executor.h 100.00% <100.00%> (ø)
src/optimizer/projection_push_down_optimizer.cpp 96.95% <100.00%> (ø)
src/planner/plan/append_create.cpp 97.14% <100.00%> (-0.30%) ⬇️
src/processor/map/map_create.cpp 100.00% <100.00%> (ø)
.../processor/operator/persistent/insert_executor.cpp 97.40% <100.00%> (+0.21%) ⬆️
... and 2 more

... and 130 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 marked this pull request as ready for review August 9, 2023 04:08
@ray6080 ray6080 merged commit c8708f6 into master Aug 10, 2023
10 checks passed
@ray6080 ray6080 deleted the dml-insert branch August 10, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants