Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up usage of common:: prefix in cpp files and fix clang warnings #1908

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 80.97% and project coverage change: -0.05% ⚠️

Comparison is base (8f9cf3f) 89.77% compared to head (0d2907d) 89.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   89.77%   89.73%   -0.05%     
==========================================
  Files         869      869              
  Lines       31171    31126      -45     
==========================================
- Hits        27985    27932      -53     
- Misses       3186     3194       +8     
Files Changed Coverage Δ
...inder/bind_expression/bind_property_expression.cpp 87.14% <ø> (ø)
src/binder/binder.cpp 96.36% <0.00%> (-0.89%) ⬇️
src/common/file_utils.cpp 77.64% <ø> (ø)
src/common/type_utils.cpp 62.31% <ø> (ø)
src/common/types/types.cpp 92.92% <0.00%> (ø)
src/common/utils.cpp 91.66% <0.00%> (-3.99%) ⬇️
src/common/vector/value_vector.cpp 99.47% <ø> (ø)
src/function/aggregate_function.cpp 81.25% <ø> (ø)
src/main/connection.cpp 91.50% <0.00%> (ø)
src/main/query_summary.cpp 77.77% <0.00%> (ø)
... and 153 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 765d6f3 into master Aug 9, 2023
10 checks passed
@ray6080 ray6080 deleted the fix-warning branch August 9, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants