Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support return after create #1906

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Support return after create #1906

merged 1 commit into from
Aug 8, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 98.48% and project coverage change: +0.01% 🎉

Comparison is base (4a12985) 89.73% compared to head (51ae0ab) 89.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
+ Coverage   89.73%   89.75%   +0.01%     
==========================================
  Files         869      869              
  Lines       31012    31050      +38     
==========================================
+ Hits        27828    27868      +40     
+ Misses       3184     3182       -2     
Files Changed Coverage Δ
src/include/planner/query_planner.h 100.00% <ø> (ø)
src/include/processor/plan_mapper.h 100.00% <ø> (ø)
src/planner/query_planner.cpp 90.62% <80.00%> (-0.42%) ⬇️
...e/planner/logical_plan/persistent/logical_create.h 100.00% <100.00%> (ø)
...de/processor/operator/persistent/insert_executor.h 100.00% <100.00%> (ø)
src/planner/operator/persistent/logical_create.cpp 96.15% <100.00%> (+1.86%) ⬆️
src/planner/plan/append_create.cpp 97.43% <100.00%> (+0.37%) ⬆️
src/planner/plan/append_extend.cpp 96.22% <100.00%> (ø)
src/planner/plan/append_scan_node.cpp 100.00% <100.00%> (ø)
src/planner/plan/plan_join_order.cpp 97.87% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we can also push the writing of lhs vectors into storage side. Maybe we should explore that option too.

@ray6080 ray6080 merged commit 924d22e into master Aug 8, 2023
10 checks passed
@ray6080 ray6080 deleted the return-after-create branch August 8, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants