Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the initialization of metadada disk arrays to wal-based transaction mechanism #1895

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 6, 2023

This is a follow up fix to #1802 .
Header pages of metadata DAs are initialized through wal.

Additionally, this PR rewrites some ddl and copy tests that are testing output message and running auto commit inside write transaction.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 68.18% and project coverage change: +0.02% 🎉

Comparison is base (765d6f3) 89.73% compared to head (7d5edb3) 89.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
+ Coverage   89.73%   89.75%   +0.02%     
==========================================
  Files         869      869              
  Lines       31126    31101      -25     
==========================================
- Hits        27930    27915      -15     
+ Misses       3196     3186      -10     
Files Changed Coverage Δ
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/processor/operator/ddl/add_property.h 100.00% <ø> (ø)
src/include/storage/storage_manager.h 100.00% <ø> (ø)
...lude/storage/storage_structure/storage_structure.h 83.33% <ø> (ø)
...torage/storage_structure/storage_structure_utils.h 100.00% <ø> (ø)
src/include/storage/store/node_column.h 100.00% <ø> (ø)
src/include/storage/wal_replayer_utils.h 100.00% <ø> (+4.00%) ⬆️
src/processor/operator/ddl/add_node_property.cpp 0.00% <0.00%> (ø)
...rc/storage/storage_structure/storage_structure.cpp 96.72% <0.00%> (-0.47%) ⬇️
src/storage/store/node_column.cpp 81.34% <0.00%> (+2.92%) ⬆️
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@semihsalihoglu-uw semihsalihoglu-uw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but I want to make sure the refactoring of insertNewPage and addNewPageToFileHandle is done. So ping me if for some reason you won't do that, I'd want to discuss.

src/catalog/catalog.cpp Show resolved Hide resolved
src/storage/storage_manager.cpp Outdated Show resolved Hide resolved
src/include/storage/storage_structure/disk_array.h Outdated Show resolved Hide resolved
src/include/storage/storage_structure/disk_array.h Outdated Show resolved Hide resolved
src/processor/operator/ddl/add_rel_property.cpp Outdated Show resolved Hide resolved
@ray6080 ray6080 merged commit e8d1a08 into master Aug 9, 2023
9 of 10 checks passed
@ray6080 ray6080 deleted the wal-da branch August 9, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants