Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change expression scan to dummy scan #1892

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR is a follow up of #1889. We enforce the invariant that a literal expression is always evaluated rather than referenced

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (3c40a45) 89.44% compared to head (45a6060) 89.47%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   89.44%   89.47%   +0.03%     
==========================================
  Files         839      839              
  Lines       30679    30699      +20     
==========================================
+ Hits        27441    27469      +28     
+ Misses       3238     3230       -8     
Files Changed Coverage Δ
...ical_plan/logical_operator/base_logical_operator.h 90.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/optimizer/filter_push_down_optimizer.cpp 99.01% <ø> (ø)
.../processor/mapper/create_factorized_table_scan.cpp 100.00% <ø> (ø)
...logical_plan/logical_operator/logical_dummy_scan.h 100.00% <100.00%> (ø)
src/include/processor/operator/index_scan.h 100.00% <100.00%> (ø)
src/planner/operator/base_logical_operator.cpp 73.23% <100.00%> (ø)
src/planner/operator/logical_dummy_scan.cpp 100.00% <100.00%> (ø)
src/planner/operator/logical_scan_node.cpp 100.00% <100.00%> (ø)
src/planner/query_planner.cpp 93.52% <100.00%> (-0.08%) ⬇️
... and 4 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU force-pushed the change-expression-scan-to-dummy-scan branch from f19609f to 45a6060 Compare August 5, 2023 06:21
@andyfengHKU andyfengHKU merged commit 2a5d542 into master Aug 5, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the change-expression-scan-to-dummy-scan branch August 5, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants