Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader for map dataType #1891

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add loader for map dataType #1891

merged 1 commit into from
Aug 7, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Aug 4, 2023

Format of map column in csv:
{key1=val1, key2=val2, key3=val3}

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 90.74% and project coverage change: -0.24% ⚠️

Comparison is base (315d7c7) 89.69% compared to head (d67eaff) 89.46%.

❗ Current head d67eaff differs from pull request most recent head d116825. Consider uploading reports for the commit d116825 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   89.69%   89.46%   -0.24%     
==========================================
  Files         868      839      -29     
  Lines       30948    30739     -209     
==========================================
- Hits        27760    27501     -259     
- Misses       3188     3238      +50     
Files Changed Coverage Δ
src/include/storage/copier/table_copy_utils.h 100.00% <ø> (ø)
src/include/storage/copier/var_list_column_chunk.h 100.00% <ø> (ø)
src/storage/copier/table_copy_utils.cpp 72.81% <85.48%> (+0.72%) ⬆️
src/common/types/types.cpp 90.00% <95.83%> (+0.63%) ⬆️
src/common/types/value.cpp 84.42% <100.00%> (+0.20%) ⬆️
src/include/storage/store/var_list_node_column.h 100.00% <100.00%> (ø)
src/storage/copier/column_chunk.cpp 73.70% <100.00%> (-3.45%) ⬇️
src/storage/copier/var_list_column_chunk.cpp 87.50% <100.00%> (+1.22%) ⬆️
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 32.93% <100.00%> (ø)
.../storage/in_mem_storage_structure/in_mem_lists.cpp 67.43% <100.00%> (ø)
... and 2 more

... and 300 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin requested a review from ray6080 August 6, 2023 13:44
src/common/types/types.cpp Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
src/storage/store/var_list_node_column.cpp Outdated Show resolved Hide resolved
src/storage/copier/table_copy_utils.cpp Outdated Show resolved Hide resolved
src/storage/copier/var_list_column_chunk.cpp Outdated Show resolved Hide resolved
src/storage/store/var_list_node_column.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 4a12985 into master Aug 7, 2023
8 checks passed
@acquamarin acquamarin deleted the map-loader branch August 7, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants