Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create operators #1887

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Refactor create operators #1887

merged 1 commit into from
Aug 4, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR refactor CREATE operators in the same way as DELETE and SET which also lays the foundation for MERGE operator.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 98.28% and project coverage change: -0.01% ⚠️

Comparison is base (8a49c40) 89.50% compared to head (92d3315) 89.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1887      +/-   ##
==========================================
- Coverage   89.50%   89.49%   -0.01%     
==========================================
  Files         838      839       +1     
  Lines       30681    30700      +19     
==========================================
+ Hits        27460    27474      +14     
- Misses       3221     3226       +5     
Files Changed Coverage Δ
...ner/logical_plan/logical_operator/logical_delete.h 100.00% <ø> (ø)
...lanner/logical_plan/logical_operator/logical_set.h 100.00% <ø> (ø)
src/planner/operator/logical_delete.cpp 100.00% <ø> (ø)
src/planner/operator/logical_set.cpp 100.00% <ø> (ø)
src/planner/plan/append_set.cpp 100.00% <ø> (ø)
src/processor/mapper/map_set.cpp 100.00% <ø> (ø)
src/planner/plan/append_create.cpp 92.30% <88.46%> (-7.70%) ⬇️
...ner/logical_plan/logical_operator/logical_create.h 100.00% <100.00%> (ø)
src/include/processor/operator/update/create.h 100.00% <100.00%> (ø)
...nclude/processor/operator/update/insert_executor.h 100.00% <100.00%> (ø)
... and 5 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

};

} // namespace planner
} // namespace kuzu
} // namespace kuzu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line here.

@andyfengHKU andyfengHKU merged commit 42d4bc7 into master Aug 4, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the create-refactor branch August 4, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants