-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Serial for node-groups #1886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check my comments? I think there are still several critical things need to be addressed to make CopyNode correct and performant. I believe the test failures are related to changes in your PR, and see if my comments can address them.
3810d4b
to
1f1c2be
Compare
Can you also check tests under |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
- Coverage 89.85% 89.77% -0.09%
==========================================
Files 869 869
Lines 31180 31276 +96
==========================================
+ Hits 28016 28077 +61
- Misses 3164 3199 +35
☔ View full report in Codecov by Sentry. |
f6ff049
to
d75d451
Compare
This PR fixes COPY from CSV, Parquet, NPY for tables which include the SERIAL data type. Also added tests.
This is a continuation of this PR: #1863, rebase/merge was too complicated so I just added the changes here