Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean bitpacking #1884

Merged
merged 1 commit into from
Aug 9, 2023

Re-merge NULL_ and BOOL and implement bool bitpacking for ColumnChunk

694395a
Select commit
Loading
Failed to load commit list.
Merged

Boolean bitpacking #1884

Re-merge NULL_ and BOOL and implement bool bitpacking for ColumnChunk
694395a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2023 in 1s

89.71% (target 80.00%)

View this Pull Request on Codecov

89.71% (target 80.00%)

Details

Codecov Report

Patch coverage: 82.53% and project coverage change: -0.02% ⚠️

Comparison is base (765d6f3) 89.73% compared to head (694395a) 89.71%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   89.73%   89.71%   -0.02%     
==========================================
  Files         869      869              
  Lines       31126    31131       +5     
==========================================
  Hits        27930    27930              
- Misses       3196     3201       +5     
Files Changed Coverage Δ
src/common/types/types.cpp 92.87% <ø> (-0.06%) ⬇️
src/include/common/null_mask.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/storage/store/node_column.h 100.00% <ø> (ø)
src/storage/storage_utils.cpp 86.15% <ø> (-0.52%) ⬇️
src/storage/store/node_column.cpp 80.06% <72.72%> (+1.65%) ⬆️
src/storage/copier/column_chunk.cpp 78.36% <83.33%> (-1.97%) ⬇️
src/common/null_mask.cpp 94.20% <100.00%> (ø)
src/include/storage/copier/column_chunk.h 96.42% <100.00%> (+0.27%) ⬆️
src/include/storage/storage_utils.h 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.