-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog rework #1877
Merged
Merged
Catalog rework #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
acquamarin
commented
Jul 31, 2023
•
edited
Loading
edited
- Move property class to a new file.
- Refactor the serialize/deserialize API of dataType.
- Merge nodeTabelSchemas and relTableSchemas to tableSchemas in catalog.
- Store vector of properties in tableSchema.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 91.14% 91.10% -0.04%
==========================================
Files 811 813 +2
Lines 29265 29346 +81
==========================================
+ Hits 26674 26737 +63
- Misses 2591 2609 +18
☔ View full report in Codecov by Sentry. |
ray6080
reviewed
Aug 1, 2023
andyfengHKU
approved these changes
Aug 1, 2023
3508ea1
to
a1db82b
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.