Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog rework #1877

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Catalog rework #1877

merged 1 commit into from
Aug 1, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jul 31, 2023

  1. Move property class to a new file.
  2. Refactor the serialize/deserialize API of dataType.
  3. Merge nodeTabelSchemas and relTableSchemas to tableSchemas in catalog.
  4. Store vector of properties in tableSchema.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 94.09% and project coverage change: -0.04% ⚠️

Comparison is base (df7a367) 91.14% compared to head (3508ea1) 91.10%.

❗ Current head 3508ea1 differs from pull request most recent head a1db82b. Consider uploading reports for the commit a1db82b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   91.14%   91.10%   -0.04%     
==========================================
  Files         811      813       +2     
  Lines       29265    29346      +81     
==========================================
+ Hits        26674    26737      +63     
- Misses       2591     2609      +18     
Files Changed Coverage Δ
...inder/bind_expression/bind_function_expression.cpp 96.66% <ø> (-0.05%) ⬇️
src/common/ser_deser.cpp 100.00% <ø> (ø)
src/function/scalar_macro_function.cpp 88.88% <ø> (ø)
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/binder/expression_binder.h 100.00% <ø> (ø)
src/include/processor/operator/ddl/create_table.h 100.00% <ø> (ø)
src/include/storage/copier/npy_reader.h 100.00% <ø> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 89.47% <ø> (ø)
...orage/storage_structure/lists/lists_update_store.h 100.00% <ø> (ø)
src/include/storage/store/rel_table.h 100.00% <ø> (ø)
... and 54 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/catalog/catalog_content.cpp Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
src/main/connection.cpp Outdated Show resolved Hide resolved
src/main/connection.cpp Outdated Show resolved Hide resolved
src/main/connection.cpp Outdated Show resolved Hide resolved
src/processor/operator/ddl/add_property.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_ddl.cpp Outdated Show resolved Hide resolved
src/catalog/catalog.cpp Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
src/binder/bind/bind_graph_pattern.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_graph_pattern.cpp Outdated Show resolved Hide resolved
src/include/catalog/catalog_content.h Outdated Show resolved Hide resolved
src/binder/bind/bind_ddl.cpp Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
src/include/catalog/property.h Outdated Show resolved Hide resolved
src/processor/operator/ddl/create_node_table.cpp Outdated Show resolved Hide resolved
src/processor/operator/ddl/create_rel_table.cpp Outdated Show resolved Hide resolved
@ray6080 ray6080 mentioned this pull request Aug 1, 2023
13 tasks
@acquamarin acquamarin merged commit 416d392 into master Aug 1, 2023
10 checks passed
@acquamarin acquamarin deleted the catalog-rework branch August 1, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants