Pin the time crate to 0.3.23 #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time moves quickly, faster than our CI rust version does
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1874 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 808 808
Lines 29205 29205
=======================================
Hits 26620 26620
Misses 2585 2585 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time moves quickly, faster than our CI rust version does. The latest version bumped the minimum rust version to 1.67, which is newer than the rustc provided by our Ubuntu 22.04-based CI images.
I suspect the only reason it's not a problem on the windows CI test is that there it looks like it's caching the build directory, so the presence of a Cargo.lock (untracked) meant it didn't update to a new version.