Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor catalog serialize/deserialize #1864

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Refactor catalog serialize/deserialize #1864

merged 1 commit into from
Jul 31, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jul 28, 2023

No description provided.

@ray6080 ray6080 requested a review from acquamarin July 28, 2023 15:05
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 88.95% and project coverage change: +0.04% 🎉

Comparison is base (95573bd) 91.12% compared to head (6e74ee0) 91.16%.

❗ Current head 6e74ee0 differs from pull request most recent head 644cd22. Consider uploading reports for the commit 644cd22 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
+ Coverage   91.12%   91.16%   +0.04%     
==========================================
  Files         806      806              
  Lines       29206    29122      -84     
==========================================
- Hits        26613    26550      -63     
+ Misses       2593     2572      -21     
Files Changed Coverage Δ
src/include/binder/copy/bound_copy.h 100.00% <ø> (ø)
src/include/binder/ddl/bound_create_table.h 100.00% <ø> (ø)
src/include/catalog/catalog.h 100.00% <ø> (ø)
...anner/logical_plan/logical_operator/logical_copy.h 100.00% <ø> (ø)
...gical_plan/logical_operator/logical_create_table.h 100.00% <ø> (ø)
...orage/storage_structure/lists/lists_update_store.h 100.00% <ø> (ø)
src/include/storage/storage_utils.h 100.00% <ø> (ø)
src/include/storage/store/table_statistics.h 95.00% <ø> (ø)
src/catalog/table_schema.cpp 83.49% <83.49%> (ø)
src/catalog/catalog.cpp 95.95% <89.47%> (+3.91%) ⬆️
... and 6 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/catalog/catalog.cpp Outdated Show resolved Hide resolved
src/catalog/catalog.cpp Outdated Show resolved Hide resolved
src/catalog/table_schema.cpp Outdated Show resolved Hide resolved
src/catalog/table_schema.cpp Outdated Show resolved Hide resolved
src/include/catalog/catalog_content.h Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
@ray6080 ray6080 force-pushed the serializer branch 2 times, most recently from 3bb00ae to de23cba Compare July 31, 2023 00:55
@ray6080 ray6080 merged commit 9be5db4 into master Jul 31, 2023
9 of 10 checks passed
@ray6080 ray6080 deleted the serializer branch July 31, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants