Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agg memory leak #1859

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fix agg memory leak #1859

merged 1 commit into from
Jul 24, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (657a830) 91.30% compared to head (366187a) 91.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
- Coverage   91.30%   91.30%   -0.01%     
==========================================
  Files         798      798              
  Lines       28999    28996       -3     
==========================================
- Hits        26478    26475       -3     
  Misses       2521     2521              
Files Changed Coverage Δ
src/common/vector/value_vector.cpp 100.00% <ø> (ø)
src/include/function/aggregate/collect.h 89.79% <ø> (ø)
...rocessor/operator/aggregate/aggregate_hash_table.h 81.81% <ø> (ø)
...cessor/operator/aggregate/aggregate_hash_table.cpp 83.14% <ø> (+0.12%) ⬆️
src/include/function/aggregate/min_max.h 91.11% <100.00%> (-0.20%) ⬇️
src/include/processor/operator/base_hash_table.h 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 7ffdc79 into master Jul 24, 2023
9 of 10 checks passed
@acquamarin acquamarin deleted the agg-memory-leak branch July 24, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants