Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional match cross product #1858

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 July 24, 2023 19:31
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (8516e87) 91.31% compared to head (14c0cee) 91.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   91.31%   91.31%   -0.01%     
==========================================
  Files         798      799       +1     
  Lines       28996    28996              
==========================================
- Hits        26478    26477       -1     
- Misses       2518     2519       +1     
Files Changed Coverage Δ
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
...ical_plan/logical_operator/logical_cross_product.h 100.00% <100.00%> (ø)
src/planner/join_order_enumerator.cpp 97.59% <100.00%> (-0.07%) ⬇️
src/planner/plan/append_cross_product.cpp 100.00% <100.00%> (ø)
src/planner/query_planner.cpp 93.57% <100.00%> (+0.42%) ⬆️
src/processor/mapper/map_cross_product.cpp 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU force-pushed the enable-optional-match-cross-product branch from 27a6129 to 14c0cee Compare July 25, 2023 05:27
@andyfengHKU andyfengHKU merged commit c1896a3 into master Jul 25, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the enable-optional-match-cross-product branch July 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants