Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change value type to unique ptr #1852

Merged
merged 2 commits into from
Jul 24, 2023
Merged

change value type to unique ptr #1852

merged 2 commits into from
Jul 24, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

src/common/types/value.cpp Show resolved Hide resolved
src/common/types/value.cpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 82.79% and no project coverage change.

Comparison is base (f6de8ea) 91.30% compared to head (74ecce0) 91.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1852   +/-   ##
=======================================
  Coverage   91.30%   91.31%           
=======================================
  Files         796      796           
  Lines       28973    28994   +21     
=======================================
+ Hits        26455    26477   +22     
+ Misses       2518     2517    -1     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/common/types/value.h 100.00% <ø> (ø)
src/include/main/settings.h 100.00% <ø> (ø)
src/common/arrow/arrow_row_batch.cpp 55.33% <33.33%> (ø)
src/main/query_result.cpp 67.96% <33.33%> (ø)
tools/nodejs_api/src_cpp/node_util.cpp 94.02% <40.00%> (-0.71%) ⬇️
tools/python_api/src_cpp/py_query_result.cpp 96.10% <50.00%> (ø)
src/common/types/value.cpp 84.22% <87.09%> (+0.43%) ⬆️
src/c_api/value.cpp 86.95% <100.00%> (ø)
src/common/types/types.cpp 89.71% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit b181462 into master Jul 24, 2023
8 of 10 checks passed
@andyfengHKU andyfengHKU deleted the logical-type-unique-ptr branch July 24, 2023 01:47
@andyfengHKU andyfengHKU mentioned this pull request Jul 24, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants