Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Optional Match as the First Clause #1849

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

andyfengHKU
Copy link
Contributor

This PR enables the following pattern OPTIONAL MATCH ... RETURN .... This is a pre-request for MERGE

@andyfengHKU andyfengHKU requested a review from ray6080 July 21, 2023 22:13
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 95.29% and project coverage change: -0.01 ⚠️

Comparison is base (77c7829) 91.30% compared to head (67d8968) 91.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
- Coverage   91.30%   91.29%   -0.01%     
==========================================
  Files         792      792              
  Lines       28765    28778      +13     
==========================================
+ Hits        26264    26273       +9     
- Misses       2501     2505       +4     
Impacted Files Coverage Δ
src/binder/bind/bind_query.cpp 100.00% <ø> (ø)
src/binder/binder.cpp 96.33% <ø> (-0.13%) ⬇️
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/parser/query/single_query.h 100.00% <ø> (ø)
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
...ude/processor/operator/hash_join/hash_join_probe.h 100.00% <ø> (ø)
src/optimizer/optimizer.cpp 100.00% <ø> (ø)
src/processor/mapper/map_union.cpp 100.00% <ø> (ø)
... and 22 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit 1988fc7 into master Jul 23, 2023
10 checks passed
@acquamarin acquamarin deleted the optional-match-first branch July 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants