Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultCollector, FTableScan, UnionAllScan refactor #1839

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 July 20, 2023 04:33
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 99.23% and project coverage change: +0.07 🎉

Comparison is base (0262e82) 91.25% compared to head (22395ab) 91.32%.

❗ Current head 22395ab differs from pull request most recent head a7ef541. Consider uploading reports for the commit a7ef541 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage   91.25%   91.32%   +0.07%     
==========================================
  Files         794      794              
  Lines       28830    28819      -11     
==========================================
+ Hits        26308    26320      +12     
+ Misses       2522     2499      -23     
Impacted Files Coverage Δ
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/planner/join_order_enumerator.cpp 97.65% <ø> (ø)
src/planner/operator/base_logical_operator.cpp 71.42% <ø> (+1.00%) ⬆️
...ude/processor/operator/table_scan/union_all_scan.h 93.75% <93.33%> (-6.25%) ⬇️
src/include/processor/operator/result_collector.h 100.00% <100.00%> (ø)
...cessor/operator/table_scan/factorized_table_scan.h 100.00% <100.00%> (+21.42%) ⬆️
.../processor/mapper/create_factorized_table_scan.cpp 100.00% <100.00%> (ø)
src/processor/mapper/create_result_collector.cpp 100.00% <100.00%> (ø)
src/processor/mapper/map_accumulate.cpp 100.00% <100.00%> (+45.00%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 60b21ca into master Jul 20, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the ftable-scan-refactor branch July 20, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants