Implement scalar macro #1836
Merged
Implement scalar macro #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1836 +/- ##
==========================================
- Coverage 91.19% 91.18% -0.02%
==========================================
Files 779 793 +14
Lines 28606 28856 +250
==========================================
+ Hits 26088 26311 +223
- Misses 2518 2545 +27
☔ View full report in Codecov by Sentry. |
andyfengHKU
requested changes
Jul 19, 2023
src/include/planner/logical_plan/logical_operator/logical_create_macro.h
Outdated
Show resolved
Hide resolved
| namespace kuzu { | ||
| namespace parser { | ||
|
|
||
| std::unique_ptr<ParsedExpression> ParsedExpressionVisitor::replaceMacroParameters( |
There was a problem hiding this comment.
This is not the exact way to write a visitor.
I think you want ParsedExpressionVisitor to only define getChildren() interface because some expression, e.g. CASE children are stored separately inside of children directly.
And you want an other class like ParsedExpressionParameterReplacor to implement such logic.
andyfengHKU
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements scalar macro.
Scalar macro allows user to create a scalar function in the catalog.
Grammar to create a scalar macro:
CREATE MACRO MACRO_NAME(PARAM1, PARAM2 := defaultVal) AS MACRO_BODY