Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception during finalize phase #1835

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Catch exception during finalize phase #1835

merged 1 commit into from
Jul 20, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jul 19, 2023

  • Add try/catch for finalizeIfNecessary.
  • Remove waitAllTasksToCompleteOrError and waitUntilEnoughTasksFinish.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.05 🎉

Comparison is base (5931a4a) 91.19% compared to head (d31cba0) 91.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   91.19%   91.24%   +0.05%     
==========================================
  Files         779      780       +1     
  Lines       28650    28588      -62     
==========================================
- Hits        26126    26086      -40     
+ Misses       2524     2502      -22     
Impacted Files Coverage Δ
src/include/common/task_system/task_scheduler.h 100.00% <ø> (ø)
src/common/task_system/task.cpp 90.90% <50.00%> (-9.10%) ⬇️
src/common/task_system/task_scheduler.cpp 98.27% <100.00%> (+28.86%) ⬆️
src/include/common/task_system/task.h 96.15% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit 0262e82 into master Jul 20, 2023
10 checks passed
@ray6080 ray6080 deleted the task-scheduler branch July 20, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants