Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicated morsel and sharedState between copy node and rel #1834

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jul 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 98.15% and project coverage change: -0.02 ⚠️

Comparison is base (5931a4a) 91.19% compared to head (09e5211) 91.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1834      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.02%     
==========================================
  Files         779      780       +1     
  Lines       28650    28614      -36     
==========================================
- Hits        26126    26088      -38     
- Misses       2524     2526       +2     
Impacted Files Coverage Δ
src/common/copier_config/copier_config.cpp 86.66% <ø> (-1.57%) ⬇️
src/include/processor/operator/copy/read_csv.h 100.00% <ø> (ø)
src/include/processor/operator/copy/read_file.h 100.00% <ø> (ø)
src/include/processor/operator/copy/read_npy.h 100.00% <ø> (ø)
src/include/processor/operator/copy/read_parquet.h 100.00% <ø> (ø)
src/include/storage/copier/rel_copy_executor.h 100.00% <ø> (ø)
src/processor/operator/copy/read_npy.cpp 100.00% <ø> (ø)
src/processor/operator/copy/read_parquet.cpp 100.00% <ø> (ø)
src/storage/copier/table_copy_utils.cpp 70.33% <66.66%> (-3.05%) ⬇️
src/include/storage/copier/rel_copier.h 95.74% <90.00%> (+0.09%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit d85691c into master Jul 19, 2023
10 checks passed
@ray6080 ray6080 deleted the clean-copy branch July 19, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants