Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages related to primary keys during copy #1830

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jul 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 91.11% and project coverage change: -0.02 ⚠️

Comparison is base (1e9d4fd) 91.19% compared to head (9d553ed) 91.18%.

❗ Current head 9d553ed differs from pull request most recent head db75e30. Consider uploading reports for the commit db75e30 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.02%     
==========================================
  Files         779      779              
  Lines       28606    28650      +44     
==========================================
+ Hits        26088    26124      +36     
- Misses       2518     2526       +8     
Impacted Files Coverage Δ
src/include/common/exception.h 82.60% <ø> (-1.40%) ⬇️
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/storage/copier/rel_copier.h 95.65% <ø> (ø)
src/include/storage/copier/rel_copy_executor.h 100.00% <ø> (ø)
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 80.23% <0.00%> (-0.55%) ⬇️
src/include/storage/index/hash_index_builder.h 80.00% <66.66%> (+0.83%) ⬆️
src/storage/copier/rel_copier.cpp 96.06% <86.20%> (-1.83%) ⬇️
src/processor/operator/copy/copy_node.cpp 94.73% <89.18%> (-2.21%) ⬇️
src/storage/copier/table_copy_utils.cpp 73.38% <91.66%> (+0.41%) ⬆️
src/include/binder/copy/bound_copy.h 100.00% <100.00%> (ø)
... and 19 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 requested a review from acquamarin July 18, 2023 15:24
src/include/binder/copy/bound_copy.h Outdated Show resolved Hide resolved
@ray6080 ray6080 merged commit 5931a4a into master Jul 19, 2023
10 checks passed
@ray6080 ray6080 deleted the copy-error branch July 19, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants