Add functions exposing conversion to Arrow ArrayData #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwinger
force-pushed
the
arrow-data
branch
2 times, most recently
from
c21e3fb
to
1bda975
Compare
benjaminwinger
force-pushed
the
arrow-data
branch
from
1bda975
to
ca40a48
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
- Coverage 91.30% 91.28% -0.02%
==========================================
Files 799 794 -5
Lines 28996 28828 -168
==========================================
- Hits 26475 26316 -159
+ Misses 2521 2512 -9
☔ View full report in Codecov by Sentry. |
benjaminwinger
commented
Jul 18, 2023
benjaminwinger
force-pushed
the
arrow-data
branch
8 times, most recently
from
a2d3e8f
to
b004523
Compare
ray6080
reviewed
Jul 21, 2023
| // Could use directly, except that we can't (yet) mark ArrowSchema as being safe to store in a | ||
| // cxx::UniquePtr | ||
| return *result.getArrowSchema(); | ||
| } |
There was a problem hiding this comment.
Add an empty line between these two functions.
src/include/c_api/kuzu.h
Outdated
| * | ||
| * It is the caller's responsibility to call the release function to release the underlying data | ||
| */ | ||
| struct ArrowArray kuzu_query_result_to_arrow_array(kuzu_query_result* query_result); |
There was a problem hiding this comment.
hmm should this be kuzu_query_result_get_next_arrow_chunk ?
benjaminwinger
force-pushed
the
arrow-data
branch
2 times, most recently
from
4c51235
to
5d9650b
Compare
ray6080
approved these changes
Jul 24, 2023
benjaminwinger
force-pushed
the
arrow-data
branch
2 times, most recently
from
76220d9
to
6f8e8ea
Compare
benjaminwinger
force-pushed
the
arrow-data
branch
from
6f8e8ea
to
2e5682f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1804
I've added functions to the C and C++ API which allow conversion of query result data to the structures defined in the Arrow C Data Interface.
The rust API takes this a step further and, similarly to the python API, converts it to the
arrow::array::ArrayDatatype (which seems a little difficult to use by itself, but converting it to more ergonomic types requires a lot of copying and probably has poor performance, so I thought it best to leave it as ArrayData and let the user decide if they want to use it directly or convert it).The arrow conversion is hidden behind an
arrowfeature to avoid pulling in the large arrow crate by default.Rust test will probably fail with the arrow feature. Testing locally the latest version of one of the arrow-rs dependencies requires rust 1.70, which is very recent; I had to manually force it to use an earlier version to get it to build on rust 1.69.