Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-label recursive join bug #1823

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 July 17, 2023 05:02
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 92.42% and project coverage change: -0.01 ⚠️

Comparison is base (f6159a4) 91.21% compared to head (33dad65) 91.20%.

❗ Current head 33dad65 differs from pull request most recent head ace38f7. Consider uploading reports for the commit ace38f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
- Coverage   91.21%   91.20%   -0.01%     
==========================================
  Files         777      779       +2     
  Lines       28568    28606      +38     
==========================================
+ Hits        26058    26091      +33     
- Misses       2510     2515       +5     
Impacted Files Coverage Δ
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/planner/operator/base_logical_operator.cpp 71.42% <75.00%> (+0.41%) ⬆️
src/planner/join_order/append_extend.cpp 95.37% <90.24%> (-4.63%) ⬇️
...rc/include/binder/expression/node_rel_expression.h 100.00% <100.00%> (ø)
...gical_plan/logical_operator/logical_label_filter.h 100.00% <100.00%> (ø)
src/processor/mapper/map_extend.cpp 96.22% <100.00%> (+1.55%) ⬆️
src/processor/mapper/map_label_filter.cpp 100.00% <100.00%> (ø)
src/processor/mapper/map_recursive_extend.cpp 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/processor/mapper/map_label_filter.cpp Outdated Show resolved Hide resolved
src/include/planner/join_order_enumerator.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the multi-label-recursive-join-fix branch from 33dad65 to ace38f7 Compare July 17, 2023 14:02
@andyfengHKU andyfengHKU merged commit 713bebd into master Jul 17, 2023
6 checks passed
@andyfengHKU andyfengHKU deleted the multi-label-recursive-join-fix branch July 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants