Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow cursor concurrency bugs #1820

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Fix overflow cursor concurrency bugs #1820

merged 1 commit into from
Jul 16, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jul 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 95.14% and project coverage change: -0.02 ⚠️

Comparison is base (deb1734) 91.20% compared to head (46f2c7e) 91.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
- Coverage   91.20%   91.19%   -0.02%     
==========================================
  Files         777      777              
  Lines       28449    28564     +115     
==========================================
+ Hits        25948    26049     +101     
- Misses       2501     2515      +14     
Impacted Files Coverage Δ
...de/storage/in_mem_storage_structure/in_mem_lists.h 80.76% <ø> (ø)
.../storage/in_mem_storage_structure/in_mem_lists.cpp 67.12% <75.00%> (+0.30%) ⬆️
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 80.78% <86.36%> (+0.05%) ⬆️
src/include/processor/operator/copy/copy_node.h 100.00% <100.00%> (ø)
...rc/include/processor/operator/copy/copy_npy_node.h 100.00% <100.00%> (ø)
src/include/storage/copier/rel_copier.h 95.65% <100.00%> (+0.78%) ⬆️
...age/in_mem_storage_structure/in_mem_column_chunk.h 89.47% <100.00%> (+0.58%) ⬆️
src/processor/mapper/map_copy.cpp 95.52% <100.00%> (-0.20%) ⬇️
src/processor/operator/copy/copy_node.cpp 96.93% <100.00%> (-0.10%) ⬇️
src/processor/operator/copy/copy_npy_node.cpp 100.00% <100.00%> (ø)
... and 1 more

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/processor/operator/copy/copy_node.h Outdated Show resolved Hide resolved
std::shared_ptr<CopyNodeSharedState> sharedState;
CopyNodeDataInfo copyNodeDataInfo;
common::CopyDescription copyDesc;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current design is to wrap all these static information into a wrapper class called xxxInfo

@ray6080 ray6080 merged commit 01da5ef into master Jul 16, 2023
10 checks passed
@ray6080 ray6080 deleted the fix-copy branch July 16, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants