Remove openssl linking for tests #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
==========================================
+ Coverage 91.18% 91.19% +0.01%
==========================================
Files 777 779 +2
Lines 28447 28606 +159
==========================================
+ Hits 25939 26088 +149
- Misses 2508 2518 +10 ☔ View full report in Codecov by Sentry. |
|
Might still be necessary on windows |
acquamarin
approved these changes
Jul 14, 2023
No longer appears to be necessary outside of windows
benjaminwinger
force-pushed
the
rust-openssl-link
branch
from
6d13b20
to
19df59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer appears to be necessary. It will have to be partially added back in by #1582 since it needs to link against the crypto library, which is why I left the
find_openssl_windowsfunction.