Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self-loop-edge #1815

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add self-loop-edge #1815

merged 1 commit into from
Jul 14, 2023

Conversation

andyfengHKU
Copy link
Contributor

Add support for self-loop edge e.g. (a)-[e]->(a). For read query, we rewrite it as (a)-[e]->(b) WHERE id(a) = id(b)

@andyfengHKU andyfengHKU requested a review from ray6080 July 13, 2023 21:33
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (eb31b2e) 91.18% compared to head (21c8c7d) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1815   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         777      777           
  Lines       28447    28459   +12     
=======================================
+ Hits        25939    25950   +11     
- Misses       2508     2509    +1     
Impacted Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 96.18% <ø> (-0.03%) ⬇️
src/include/binder/expression/rel_expression.h 100.00% <ø> (ø)
src/binder/bind/bind_reading_clause.cpp 95.91% <100.00%> (+1.32%) ⬆️
src/include/binder/expression/expression.h 91.30% <100.00%> (+0.39%) ⬆️
...rc/include/binder/expression/node_rel_expression.h 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 0662374 into master Jul 14, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the self-loop-edge branch July 14, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants