Implemented support for RecursiveRel in the Rust API #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 91.18% 91.20% +0.02%
==========================================
Files 777 777
Lines 28447 28450 +3
==========================================
+ Hits 25939 25949 +10
+ Misses 2508 2501 -7 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Jul 13, 2023
tools/rust_api/src/logical_type.rs
Outdated
| @@ -121,6 +127,7 @@ impl From<&LogicalType> for cxx::UniquePtr<ffi::LogicalType> { | |||
| | LogicalType::String | |||
| | LogicalType::Blob | |||
| | LogicalType::Node | |||
| | LogicalType::RecursiveRel | |||
There was a problem hiding this comment.
Let's always put RecursiveRel branch after REL
benjaminwinger
force-pushed
the
rust-recursive-rel
branch
3 times, most recently
from
5b4254f
to
a901e98
Compare
benjaminwinger
force-pushed
the
rust-recursive-rel
branch
from
a901e98
to
8da8c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.