Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store raw blob data in value #1774

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Store raw blob data in value #1774

merged 5 commits into from
Jul 7, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@acquamarin acquamarin requested a review from mewim July 7, 2023 01:25
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4dd9770) 90.89% compared to head (15ced33) 90.89%.

❗ Current head 15ced33 differs from pull request most recent head 298ce21. Consider uploading reports for the commit 298ce21 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1774   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files         771      771           
  Lines       28130    28136    +6     
=======================================
+ Hits        25569    25575    +6     
  Misses       2561     2561           
Impacted Files Coverage Δ
src/common/types/blob.cpp 86.66% <100.00%> (ø)
src/common/types/value.cpp 85.94% <100.00%> (+0.06%) ⬆️
tools/nodejs_api/src_cpp/node_util.cpp 93.54% <100.00%> (+0.10%) ⬆️
tools/python_api/src_cpp/py_query_result.cpp 96.02% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit 761585c into master Jul 7, 2023
5 checks passed
@mewim mewim deleted the blob-val branch July 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants