Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for SERIAL and BLOB for client APIs #1773

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Jul 7, 2023

This PR adds bindings for SERIAL and BLOB types for client APIs.

Note:
The BLOB type is currently returned as Strings to be consistent with C++ and no unit tests have been added. If #1770 changes the return type of BLOB, we should use the native BLOB types for each programming language accordingly.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c13c1f0) 90.89% compared to head (6c0e63b) 90.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1773   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files         771      771           
  Lines       28130    28130           
=======================================
  Hits        25569    25569           
  Misses       2561     2561           
Impacted Files Coverage Δ
tools/java_api/src/jni/kuzu_java.cpp 78.80% <100.00%> (ø)
tools/nodejs_api/src_cpp/node_util.cpp 93.44% <100.00%> (ø)
tools/python_api/src_cpp/py_query_result.cpp 95.97% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit 4dd9770 into master Jul 7, 2023
8 of 9 checks passed
@mewim mewim deleted the serial-blob-binding branch July 7, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants