Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named path #1771

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Named path #1771

merged 1 commit into from
Jul 7, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR add named path support

@andyfengHKU andyfengHKU requested a review from ray6080 July 6, 2023 23:25
src/include/expression_evaluator/path_evaluator.h Outdated Show resolved Hide resolved
src/expression_evaluator/path_evaluator.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 96.24% and project coverage change: +0.03 🎉

Comparison is base (4dd9770) 90.89% compared to head (47360a3) 90.93%.

❗ Current head 47360a3 differs from pull request most recent head 27aaae8. Consider uploading reports for the commit 27aaae8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
+ Coverage   90.89%   90.93%   +0.03%     
==========================================
  Files         771      774       +3     
  Lines       28130    28316     +186     
==========================================
+ Hits        25569    25748     +179     
- Misses       2561     2568       +7     
Impacted Files Coverage Δ
src/common/expression_type.cpp 67.64% <0.00%> (-2.05%) ⬇️
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/binder/expression/rel_expression.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/include/planner/projection_planner.h 100.00% <ø> (ø)
src/planner/projection_planner.cpp 100.00% <ø> (+1.00%) ⬆️
.../include/expression_evaluator/node_rel_evaluator.h 77.77% <50.00%> (ø)
src/include/expression_evaluator/path_evaluator.h 77.77% <77.77%> (ø)
src/binder/bind/bind_graph_pattern.cpp 95.29% <94.87%> (-0.29%) ⬇️
src/expression_evaluator/path_evaluator.cpp 98.50% <98.50%> (ø)
... and 9 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 52bc493 into master Jul 7, 2023
8 of 9 checks passed
@andyfengHKU andyfengHKU deleted the named-path branch July 7, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants