Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concat-null #1765

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix concat-null #1765

merged 1 commit into from
Jul 6, 2023

Conversation

acquamarin
Copy link
Collaborator

  1. Fix concat-null function bug.
  2. Added
void ValueVector::copyFromVectorData(
    uint64_t posToCopy, const ValueVector* srcVector, uint64_t srcPos)

which removes the assumption that the srcValue must be null

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a129767) 91.17% compared to head (4b20699) 91.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
- Coverage   91.17%   91.17%   -0.01%     
==========================================
  Files         769      769              
  Lines       28177    28153      -24     
==========================================
- Hits        25690    25668      -22     
+ Misses       2487     2485       -2     
Impacted Files Coverage Δ
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/common/vector/value_vector.cpp 100.00% <100.00%> (ø)
src/expression_evaluator/case_evaluator.cpp 81.72% <100.00%> (-0.39%) ⬇️
src/function/vector_list_operation.cpp 90.10% <100.00%> (-0.09%) ⬇️
src/function/vector_struct_operations.cpp 94.82% <100.00%> (+0.98%) ⬆️
...unction/list/operations/base_list_sort_operation.h 94.44% <100.00%> (-0.16%) ⬇️
...e/function/list/operations/list_append_operation.h 100.00% <100.00%> (ø)
...e/function/list/operations/list_concat_operation.h 100.00% <100.00%> (ø)
.../function/list/operations/list_prepend_operation.h 100.00% <100.00%> (ø)
...de/function/list/operations/list_slice_operation.h 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit 7845162 into master Jul 6, 2023
9 checks passed
@acquamarin acquamarin deleted the list-null-fix branch July 6, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants