Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1727 #1761

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Issue 1727 #1761

merged 1 commit into from
Jul 5, 2023

Conversation

andyfengHKU
Copy link
Contributor

Fix issue #1727

@andyfengHKU andyfengHKU requested a review from ray6080 July 5, 2023 04:19
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 96.66% and no project coverage change.

Comparison is base (7ecf3b4) 91.16% compared to head (d15e3a1) 91.17%.

❗ Current head d15e3a1 differs from pull request most recent head cb6838f. Consider uploading reports for the commit cb6838f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1761   +/-   ##
=======================================
  Coverage   91.16%   91.17%           
=======================================
  Files         769      769           
  Lines       28089    28128   +39     
=======================================
+ Hits        25608    25645   +37     
- Misses       2481     2483    +2     
Impacted Files Coverage Δ
src/optimizer/projection_push_down_optimizer.cpp 99.25% <ø> (-0.03%) ⬇️
src/processor/mapper/map_extend.cpp 94.66% <90.90%> (-1.63%) ⬇️
src/binder/bind/bind_graph_pattern.cpp 95.30% <100.00%> (-0.17%) ⬇️
src/common/vector/value_vector.cpp 100.00% <100.00%> (ø)
src/include/binder/expression/rel_expression.h 100.00% <100.00%> (ø)
src/include/processor/operator/filter.h 100.00% <100.00%> (ø)
src/planner/join_order/append_extend.cpp 100.00% <100.00%> (ø)
src/processor/operator/filter.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit f8f3a93 into master Jul 5, 2023
9 checks passed
@acquamarin acquamarin deleted the issue-1727 branch July 5, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants