Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current setting/version function #1760

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Current setting/version function #1760

merged 1 commit into from
Jul 5, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jul 5, 2023

  1. Added db_version("") function which returns the current database version.
  2. Added current_setting(settingName) function which returns the value of the setting.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 98.41% and project coverage change: -0.01 ⚠️

Comparison is base (7ecf3b4) 91.16% compared to head (7b14038) 91.16%.

❗ Current head 7b14038 differs from pull request most recent head efdf0ba. Consider uploading reports for the commit efdf0ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1760      +/-   ##
==========================================
- Coverage   91.16%   91.16%   -0.01%     
==========================================
  Files         769      769              
  Lines       28089    28138      +49     
==========================================
+ Hits        25608    25652      +44     
- Misses       2481     2486       +5     
Impacted Files Coverage Δ
src/binder/bind/bind_reading_clause.cpp 94.44% <ø> (ø)
src/include/main/client_context.h 100.00% <ø> (ø)
src/main/db_config.cpp 100.00% <ø> (ø)
src/main/client_context.cpp 92.30% <80.00%> (-7.70%) ⬇️
src/function/built_in_table_operations.cpp 83.33% <100.00%> (+5.55%) ⬆️
src/function/table_operations.cpp 100.00% <100.00%> (ø)
src/include/binder/binder.h 100.00% <100.00%> (ø)
src/include/function/table_operations.h 100.00% <100.00%> (ø)
src/include/main/settings.h 100.00% <100.00%> (ø)
src/main/connection.cpp 93.20% <100.00%> (-1.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/binder/binder_test.cpp Outdated Show resolved Hide resolved
src/include/binder/binder.h Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit a129767 into master Jul 5, 2023
9 checks passed
@acquamarin acquamarin deleted the current-setting branch July 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants