Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct-field-name printing #1759

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Struct-field-name printing #1759

merged 1 commit into from
Jul 4, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jul 4, 2023

Change the storage/printing of struct field name to case sensitive.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (fc7fa9a) 91.15% compared to head (38e1aaf) 91.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
+ Coverage   91.15%   91.16%   +0.01%     
==========================================
  Files         769      769              
  Lines       28089    28089              
==========================================
+ Hits        25604    25608       +4     
+ Misses       2485     2481       -4     
Impacted Files Coverage Δ
src/binder/bind/bind_ddl.cpp 100.00% <ø> (ø)
src/include/binder/bound_statement_result.h 100.00% <ø> (ø)
src/binder/bound_statement_result.cpp 91.66% <100.00%> (-0.65%) ⬇️
src/common/types/types.cpp 88.91% <100.00%> (-0.06%) ⬇️
src/include/binder/bound_explain.h 100.00% <100.00%> (ø)
src/include/common/string_utils.h 100.00% <100.00%> (ø)
src/include/common/types/types.h 100.00% <100.00%> (ø)
...unction/list/operations/base_list_sort_operation.h 94.59% <100.00%> (-0.28%) ⬇️
src/processor/mapper/map_path_property_probe.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit 7ecf3b4 into master Jul 4, 2023
9 checks passed
@mewim mewim deleted the struct-field-name branch July 4, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants