Example Fix and CI #1753
Merged
Example Fix and CI #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1753 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 769 769
Lines 28089 28089
=======================================
Hits 25608 25608
Misses 2481 2481 ☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Jul 4, 2023
examples/cpp/CMakeLists.txt
Outdated
| @@ -4,6 +4,7 @@ project(example-cpp) | |||
| set(CMAKE_CXX_STANDARD 20) | |||
|
|
|||
| include_directories(../../src/include) | |||
| include_directories(../../third_party/nlohmann_json) | |||
There was a problem hiding this comment.
Can you double check if we need this third party any more? I think we removed this dependency since #1751
There was a problem hiding this comment.
No, it's no longer needed. The example now works without any modifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd noticed that the C++ example doesn't compile any more (
json_fwd.hpphas been added into one of the includes, presumably since that example was written). I've fixed it, and added CI jobs for the examples, since while they aren't essential parts of the software, they are less helpful if they get out of date and fail to build when someone tries them out.