Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind group by agg rework #1748

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Bind group by agg rework #1748

merged 1 commit into from
Jul 2, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR moves group by & aggregate binding logic from planner to binder

@andyfengHKU andyfengHKU requested a review from ray6080 July 1, 2023 19:52
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage: 97.87% and project coverage change: +0.01 🎉

Comparison is base (bd0f58d) 91.41% compared to head (2754a3c) 91.42%.

❗ Current head 2754a3c differs from pull request most recent head 424664d. Consider uploading reports for the commit 424664d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
+ Coverage   91.41%   91.42%   +0.01%     
==========================================
  Files         767      766       -1     
  Lines       27495    27507      +12     
==========================================
+ Hits        25135    25149      +14     
+ Misses       2360     2358       -2     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/parser/expression/parsed_expression.h 100.00% <ø> (ø)
...ude/planner/logical_plan/logical_operator/schema.h 100.00% <ø> (ø)
src/include/planner/projection_planner.h 100.00% <ø> (ø)
src/planner/operator/logical_aggregate.cpp 97.67% <66.66%> (ø)
src/binder/bind/bind_projection_clause.cpp 97.70% <98.36%> (-0.27%) ⬇️
src/include/binder/expression/expression.h 90.00% <100.00%> (+0.52%) ⬆️
...r/query/return_with_clause/bound_projection_body.h 100.00% <100.00%> (ø)
src/planner/operator/logical_projection.cpp 100.00% <100.00%> (ø)
src/planner/operator/schema.cpp 81.39% <100.00%> (+1.39%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 3c20011 into master Jul 2, 2023
7 checks passed
@andyfengHKU andyfengHKU deleted the bind-group-by-agg branch July 2, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants