Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make table functions as part of the reading clause #1737

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 29, 2023

This PR makes all the table functions as part of the reading clause.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 99.23% and project coverage change: +0.01 🎉

Comparison is base (184d8df) 91.38% compared to head (22078da) 91.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
+ Coverage   91.38%   91.39%   +0.01%     
==========================================
  Files         759      760       +1     
  Lines       27416    27433      +17     
==========================================
+ Hits        25053    25073      +20     
+ Misses       2363     2360       -3     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/processor/processor.cpp 100.00% <ø> (ø)
src/planner/operator/base_logical_operator.cpp 72.05% <50.00%> (ø)
... and 23 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/antlr4/Cypher.g4 Outdated Show resolved Hide resolved
src/antlr4/Cypher.g4 Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 0c30785 into master Jun 29, 2023
9 checks passed
@acquamarin acquamarin deleted the call-statement branch June 29, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants