Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing framework: add ${count} to REPEAT #1733

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented Jun 28, 2023

This PR adds ${count} to support using the count number to distinguish names. This might be useful to some use cases, for example, creating a node table with 2000 different columns:

-GROUP Test
-DATASET CSV empty

--

-CASE Dummy

-DEFINE COLS REPEAT 2000 "Col${count} STRING, "
-STATEMENT CREATE NODE TABLE Person(${COLS} PRIMARY KEY(Col0))
---- ok

closes #1729

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 99.25% and no project coverage change.

Comparison is base (8f029ed) 91.39% compared to head (5851a38) 91.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1733   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         759      760    +1     
  Lines       27416    27432   +16     
=======================================
+ Hits        25056    25071   +15     
- Misses       2360     2361    +1     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/processor/processor.cpp 100.00% <ø> (ø)
src/planner/operator/base_logical_operator.cpp 72.05% <50.00%> (ø)
... and 24 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase the master and refactor the NodeTableWith300ColumnsInfo test using the new testing statement?

@rfdavid rfdavid merged commit 8172ee7 into kuzudb:master Jun 29, 2023
9 checks passed
@rfdavid rfdavid deleted the repeat_count branch June 29, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing framework: support ${count} on REPEAT
2 participants