Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement table function framework #1731

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Implement table function framework #1731

merged 1 commit into from
Jun 28, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 28, 2023

This PR implements the table funciton framework and thetable_info(tableName) table function which returns the property names of the given table.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 98.50% and project coverage change: +0.02 🎉

Comparison is base (faada3f) 91.35% compared to head (a2ce432) 91.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
+ Coverage   91.35%   91.38%   +0.02%     
==========================================
  Files         749      759      +10     
  Lines       27264    27416     +152     
==========================================
+ Hits        24907    25054     +147     
- Misses       2357     2362       +5     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/function/built_in_vector_operations.h 100.00% <ø> (ø)
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/processor/processor.cpp 100.00% <ø> (ø)
src/planner/operator/base_logical_operator.cpp 72.05% <50.00%> (-0.67%) ⬇️
src/function/built_in_table_operations.cpp 77.77% <77.77%> (ø)
... and 27 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/binder/bind/bind_call.cpp Outdated Show resolved Hide resolved
src/include/processor/operator/call/call_table_func.h Outdated Show resolved Hide resolved
src/processor/mapper/map_call_config.cpp Outdated Show resolved Hide resolved
src/antlr4/Cypher.g4 Show resolved Hide resolved
src/function/built_in_vector_operations.cpp Show resolved Hide resolved
src/function/table_operations.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 184d8df into master Jun 28, 2023
9 checks passed
@acquamarin acquamarin deleted the table-func branch June 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants